[PATCH] D95232: Symbolizer - Teach symbolizer to work directly on object file.

praveen velliengiri via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 16 09:07:38 PST 2021


pvellien added a comment.

In D95232#2564264 <https://reviews.llvm.org/D95232#2564264>, @dblaikie wrote:

> Generally there should be test coverage - otherwise these APIs are likely to be cleaned up as unused, even if the chance of actual bugs in them is small (since they're just simple wrappers).
>
> Perhaps some unit testing would be suitable?

Hi dave, thanks for your comments. I was worried about this thing. But there are no existing tools in llvm that work on object file directly expect there is a usage for one existing API - symbolizeCode. I don't know how it is reliable to add unit tests, I would highly appreciate your thoughts on this. thanks


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95232/new/

https://reviews.llvm.org/D95232



More information about the llvm-commits mailing list