[PATCH] D95094: [ShrinkWrap] Enable Shrinkwrapping on 32 and 64 bit AIX, and 64 bit ELF

[Sean Fertile via Phabricator via llvm-commits]

sfertile added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/ppc-shrink-wrapping.ll:311
 ; Make sure we save the link register
-; CHECK: mflr {{[0-9]+}}
+; CHECK-LINUX: mflr {{[0-9]+}}
 ;
----------------
`CHECK-LINUX` -> `CHECK`


================
Comment at: llvm/test/CodeGen/PowerPC/ppc-shrink-wrapping.ll:397
 ; CHECK-NEXT: blr
+;
 define i32 @emptyFrame() {
----------------
Real minor nit: delete this line.


================
Comment at: llvm/test/CodeGen/PowerPC/ppc-shrink-wrapping.ll:434
+; CHECK-32-DAG: lwz 14, -[[STACK_OFFSET]](1) # 4-byte Folded Reload
+; CHECK-LINUX: nop
 ; CHECK: blr
----------------
`CHECK-LINUX` -> `CHECK-DAG`


================
Comment at: llvm/test/CodeGen/PowerPC/ppc-shrink-wrapping.ll:442
 ; CHECK-NEXT: blr
-; 
+;
 define i32 @inlineAsm(i32 %cond, i32 %N) {
----------------
Real minor nit: delete this line.


================
Comment at: llvm/test/CodeGen/PowerPC/ppc-shrink-wrapping.ll:634
 ; Another infinite loop test this time with two nested infinite loop.
-; CHECK-LABEL: infiniteloop3
-; CHECK: Lfunc_begin[[FUNCNUM:[0-9]+]]
-; CHECK: bclr
-; CHECK: Lfunc_end[[FUNCNUM]]
+; CHECK-LABEL: {{.*}}infiniteloop3
+;
----------------
The original test is checking that we generate a `bclr` instruction in the functions body (ie in-between func_begin and func_end). The Label checks ensures we are inside the expected function though so we can simplify this to:

```
; CHECK-LABEL: {{.*}}infiniteloop3
; CHECK: bclr
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95094/new/

https://reviews.llvm.org/D95094