[PATCH] D95246: [test] Use host platform specific error message substitution in lit tests

Tue Feb 16 05:50:27 PST 2021

abhina.sreeskantharajan added a comment.

In D95246#2564137 <https://reviews.llvm.org/D95246#2564137>, @ASDenysPetrov wrote:

> This patch causes fails in a bunch of test files. When I roll it back, it passes.
> Below you can see fail output of `ubsan-blacklist-vfs.c` and `basic-block-sections.c`.
> F15539561: fail_output.txt <https://reviews.llvm.org/F15539561>
>
> Please, pay attention to this. 
> I'm using build on Win10 + GCC config.
>
> P.S. The similar trouble is in D95808 <https://reviews.llvm.org/D95808>. I've commented there as well.

Hi Denys, thanks for bringing this to my attention, I'll look into this failure. I do know that the CI test for this patch and the other patch ran on Windows and did not report any errors. https://buildkite.com/llvm-project/premerge-checks/builds/23727#63570ad0-0e74-4825-b1dc-8f53a4d4dad0
Do you know what is different between your environments which is causing the spelling to be capitalized? This might help me determine how to fix the current host platform check in llvm/utils/lit/lit/llvm/config.py.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95246/new/

https://reviews.llvm.org/D95246