[PATCH] D92285: [VPlan] Manage scalarized values using VPValues.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 16 01:07:46 PST 2021


fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:9045
+  State.ILV->widenPHIInstruction(cast<PHINode>(getUnderlyingValue()), RdxDesc,
+                                 StartV, State.UF, State.VF, this, State);
 }
----------------
gilr wrote:
> gilr wrote:
> > No need to pass as arguments now that State itself is passed.
> > No need to pass as arguments now that State itself is passed.
> 
> Does that make sense?
> Does that make sense?

Yes, sorry I totally missed that I did not update this so far! Fixed now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92285/new/

https://reviews.llvm.org/D92285



More information about the llvm-commits mailing list