[PATCH] D96727: [NPM] Properly reset parent loop after loop passes

[Mikael Holmén via Phabricator via llvm-commits]

uabelho added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopPassManager.cpp:117
 
+#ifndef NDEBUG
+    // After running the loop pass, the parent loop might change and we need to
----------------
I don't know this code at all, but I have to say I feel a little bit uneasy about a bugfix that only adds stuff guarded by #ifndef NDEBUG.
I'm not saying it's the case here because I don't know at all, but this *could* mean that we only fix the problem when compiling with asserts, and then in a production build the bug still exist.

Would it hurt much to always set the parent loop so it's worth putting it in an ifndef?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96727/new/

https://reviews.llvm.org/D96727