[PATCH] D96734: Transforms: Clone distinct nodes in metadata mapper unless RF_ReuseAndMutateDistinctMDs

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added a comment.

Thanks. I am not very familiar with processSubprogram() or the implication of the other changes in CloneFunction.cpp, so will leave it to @aprantl or someone more familiar with the debug info details to review. I just have a small suggestion on the revert part.



================
Comment at: llvm/lib/Transforms/Utils/ValueMapper.cpp:546
                        ? M.mapToSelf(&N)
-                       : M.mapToMetadata(&N, cloneOrBuildODR(N))));
+                       : M.mapToMetadata(&N, cloneDistinct(N))));
   return DistinctWorklist.back();
----------------
Why not just call MDNode::replaceWithDistinct(N.clone()) directly?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96734/new/

https://reviews.llvm.org/D96734