[llvm] 22f00f6 - [CodeGen] Use range-based for loops (NFC)
Kazu Hirata via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 15 14:47:17 PST 2021
Author: Kazu Hirata
Date: 2021-02-15T14:46:11-08:00
New Revision: 22f00f61dd5483a9fdaed3b7592d392c23b3646a
URL: https://github.com/llvm/llvm-project/commit/22f00f61dd5483a9fdaed3b7592d392c23b3646a
DIFF: https://github.com/llvm/llvm-project/commit/22f00f61dd5483a9fdaed3b7592d392c23b3646a.diff
LOG: [CodeGen] Use range-based for loops (NFC)
Added:
Modified:
llvm/lib/CodeGen/AggressiveAntiDepBreaker.cpp
llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp
llvm/lib/CodeGen/MIRParser/MIRParser.cpp
llvm/lib/CodeGen/MachineBasicBlock.cpp
llvm/lib/CodeGen/MachineFunction.cpp
llvm/lib/CodeGen/MachineInstr.cpp
llvm/lib/CodeGen/MachineInstrBundle.cpp
llvm/lib/CodeGen/MachineOutliner.cpp
Removed:
################################################################################
diff --git a/llvm/lib/CodeGen/AggressiveAntiDepBreaker.cpp b/llvm/lib/CodeGen/AggressiveAntiDepBreaker.cpp
index 0146d038f670..87a3cede601b 100644
--- a/llvm/lib/CodeGen/AggressiveAntiDepBreaker.cpp
+++ b/llvm/lib/CodeGen/AggressiveAntiDepBreaker.cpp
@@ -952,10 +952,9 @@ unsigned AggressiveAntiDepBreaker::BreakAntiDependencies(
<< printReg(AntiDepReg, TRI) << ":");
// Handle each group register...
- for (std::map<unsigned, unsigned>::iterator
- S = RenameMap.begin(), E = RenameMap.end(); S != E; ++S) {
- unsigned CurrReg = S->first;
- unsigned NewReg = S->second;
+ for (const auto &P : RenameMap) {
+ unsigned CurrReg = P.first;
+ unsigned NewReg = P.second;
LLVM_DEBUG(dbgs() << " " << printReg(CurrReg, TRI) << "->"
<< printReg(NewReg, TRI) << "("
diff --git a/llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp b/llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp
index 8a8bb44cbca6..315272e6991c 100644
--- a/llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp
+++ b/llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp
@@ -1531,10 +1531,9 @@ void DwarfUnit::constructEnumTypeDIE(DIE &Buffer, const DICompositeType *CTy) {
}
void DwarfUnit::constructContainingTypeDIEs() {
- for (auto CI = ContainingTypeMap.begin(), CE = ContainingTypeMap.end();
- CI != CE; ++CI) {
- DIE &SPDie = *CI->first;
- const DINode *D = CI->second;
+ for (auto &P : ContainingTypeMap) {
+ DIE &SPDie = *P.first;
+ const DINode *D = P.second;
if (!D)
continue;
DIE *NDie = getDIE(D);
diff --git a/llvm/lib/CodeGen/MIRParser/MIRParser.cpp b/llvm/lib/CodeGen/MIRParser/MIRParser.cpp
index ffa9aeb21edb..2d8613b41311 100644
--- a/llvm/lib/CodeGen/MIRParser/MIRParser.cpp
+++ b/llvm/lib/CodeGen/MIRParser/MIRParser.cpp
@@ -646,10 +646,9 @@ bool MIRParserImpl::setupRegisterInfo(const PerFunctionMIParsingState &PFS,
}
};
- for (auto I = PFS.VRegInfosNamed.begin(), E = PFS.VRegInfosNamed.end();
- I != E; I++) {
- const VRegInfo &Info = *I->second;
- populateVRegInfo(Info, Twine(I->first()));
+ for (const auto &P : PFS.VRegInfosNamed) {
+ const VRegInfo &Info = *P.second;
+ populateVRegInfo(Info, Twine(P.first()));
}
for (auto P : PFS.VRegInfos) {
diff --git a/llvm/lib/CodeGen/MachineBasicBlock.cpp b/llvm/lib/CodeGen/MachineBasicBlock.cpp
index eafc82672db6..aa3f3a8e8470 100644
--- a/llvm/lib/CodeGen/MachineBasicBlock.cpp
+++ b/llvm/lib/CodeGen/MachineBasicBlock.cpp
@@ -1086,10 +1086,9 @@ MachineBasicBlock *MachineBasicBlock::SplitCriticalEdge(
I != E; ++I)
NewTerminators.push_back(&*I);
- for (SmallVectorImpl<MachineInstr*>::iterator I = Terminators.begin(),
- E = Terminators.end(); I != E; ++I) {
- if (!is_contained(NewTerminators, *I))
- Indexes->removeMachineInstrFromMaps(**I);
+ for (MachineInstr *Terminator : Terminators) {
+ if (!is_contained(NewTerminators, Terminator))
+ Indexes->removeMachineInstrFromMaps(*Terminator);
}
}
diff --git a/llvm/lib/CodeGen/MachineFunction.cpp b/llvm/lib/CodeGen/MachineFunction.cpp
index 3f44578b1a2c..3f90df19f924 100644
--- a/llvm/lib/CodeGen/MachineFunction.cpp
+++ b/llvm/lib/CodeGen/MachineFunction.cpp
@@ -850,9 +850,8 @@ int MachineFunction::getFilterIDFor(std::vector<unsigned> &TyIds) {
// If the new filter coincides with the tail of an existing filter, then
// re-use the existing filter. Folding filters more than this requires
// re-ordering filters and/or their elements - probably not worth it.
- for (std::vector<unsigned>::iterator I = FilterEnds.begin(),
- E = FilterEnds.end(); I != E; ++I) {
- unsigned i = *I, j = TyIds.size();
+ for (unsigned i : FilterEnds) {
+ unsigned j = TyIds.size();
while (i && j)
if (FilterIds[--i] != TyIds[--j])
@@ -1150,11 +1149,9 @@ MachineConstantPool::~MachineConstantPool() {
Deleted.insert(Constants[i].Val.MachineCPVal);
delete Constants[i].Val.MachineCPVal;
}
- for (DenseSet<MachineConstantPoolValue*>::iterator I =
- MachineCPVsSharingEntries.begin(), E = MachineCPVsSharingEntries.end();
- I != E; ++I) {
- if (Deleted.count(*I) == 0)
- delete *I;
+ for (MachineConstantPoolValue *CPV : MachineCPVsSharingEntries) {
+ if (Deleted.count(CPV) == 0)
+ delete CPV;
}
}
diff --git a/llvm/lib/CodeGen/MachineInstr.cpp b/llvm/lib/CodeGen/MachineInstr.cpp
index b6cfd7dcbfbc..94afaff8e9e0 100644
--- a/llvm/lib/CodeGen/MachineInstr.cpp
+++ b/llvm/lib/CodeGen/MachineInstr.cpp
@@ -2057,9 +2057,8 @@ void MachineInstr::setPhysRegsDeadExcept(ArrayRef<Register> UsedRegs,
// This is a call with a register mask operand.
// Mask clobbers are always dead, so add defs for the non-dead defines.
if (HasRegMask)
- for (ArrayRef<Register>::iterator I = UsedRegs.begin(), E = UsedRegs.end();
- I != E; ++I)
- addRegisterDefined(*I, &TRI);
+ for (const Register &UsedReg : UsedRegs)
+ addRegisterDefined(UsedReg, &TRI);
}
unsigned
diff --git a/llvm/lib/CodeGen/MachineInstrBundle.cpp b/llvm/lib/CodeGen/MachineInstrBundle.cpp
index 50456e489ea1..6ca97031b92a 100644
--- a/llvm/lib/CodeGen/MachineInstrBundle.cpp
+++ b/llvm/lib/CodeGen/MachineInstrBundle.cpp
@@ -47,11 +47,9 @@ bool UnpackMachineBundles::runOnMachineFunction(MachineFunction &MF) {
return false;
bool Changed = false;
- for (MachineFunction::iterator I = MF.begin(), E = MF.end(); I != E; ++I) {
- MachineBasicBlock *MBB = &*I;
-
- for (MachineBasicBlock::instr_iterator MII = MBB->instr_begin(),
- MIE = MBB->instr_end(); MII != MIE; ) {
+ for (MachineBasicBlock &MBB : MF) {
+ for (MachineBasicBlock::instr_iterator MII = MBB.instr_begin(),
+ MIE = MBB.instr_end(); MII != MIE; ) {
MachineInstr *MI = &*MII;
// Remove BUNDLE instruction and the InsideBundle flags from bundled
@@ -256,8 +254,7 @@ llvm::finalizeBundle(MachineBasicBlock &MBB,
/// MachineFunction. Return true if any bundles are finalized.
bool llvm::finalizeBundles(MachineFunction &MF) {
bool Changed = false;
- for (MachineFunction::iterator I = MF.begin(), E = MF.end(); I != E; ++I) {
- MachineBasicBlock &MBB = *I;
+ for (MachineBasicBlock &MBB : MF) {
MachineBasicBlock::instr_iterator MII = MBB.instr_begin();
MachineBasicBlock::instr_iterator MIE = MBB.instr_end();
if (MII == MIE)
diff --git a/llvm/lib/CodeGen/MachineOutliner.cpp b/llvm/lib/CodeGen/MachineOutliner.cpp
index 02998d41d831..3751d948ea3c 100644
--- a/llvm/lib/CodeGen/MachineOutliner.cpp
+++ b/llvm/lib/CodeGen/MachineOutliner.cpp
@@ -518,9 +518,8 @@ void MachineOutliner::findCandidates(
// First, find all of the repeated substrings in the tree of minimum length
// 2.
std::vector<Candidate> CandidatesForRepeatedSeq;
- for (auto It = ST.begin(), Et = ST.end(); It != Et; ++It) {
+ for (const SuffixTree::RepeatedSubstring &RS : ST) {
CandidatesForRepeatedSeq.clear();
- SuffixTree::RepeatedSubstring RS = *It;
unsigned StringLen = RS.Length;
for (const unsigned &StartIdx : RS.StartIndices) {
unsigned EndIdx = StartIdx + StringLen - 1;
More information about the llvm-commits
mailing list