[PATCH] D96671: [GlobalISel] Implement narrowScalar for UADDO/USUBO
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 15 14:29:20 PST 2021
arsenm added inline comments.
================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:4488
+ Register Src2 = MI.getOperand(NumDefs + 1).getReg();
+ Optional<Register> CarryDst = None;
+ if (NumDefs >= 2)
----------------
I don't like using Optional for Register, a default constructed Register behaves like none
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96671/new/
https://reviews.llvm.org/D96671
More information about the llvm-commits
mailing list