[PATCH] D96289: Add support for YAML output style to llvm-symbolizer

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D96289#2562717 <https://reviews.llvm.org/D96289#2562717>, @aorlov wrote:

> In D96289#2560919 <https://reviews.llvm.org/D96289#2560919>, @MaskRay wrote:
>
>> The line based output can be straightforwardly parsed
>
> And this is fine. I do not see how this patch could prevent your users from parsing the line based output. It is quite the opposite, they are even better protected, as any change in YAML output style would not change what they depend on.

It is not that this patch could prevent my users. It is my question about whether the YAML output adds new value.

- Most users parse the line based output, as they did with addr2line. There is a `--verbose` option which can make the output less ambiguous.  https://github.com/google/pprof/blob/master/internal/binutils/addr2liner_llvm.go#L113 is an example how easy/robust it is. (The Go tool is used by many groups in production.)
- Users want a lot of flexibility - they should use the DebugInfo/Symbolize APIs.

The two cover the spectrum I can think of. If really we need an interchange format (I have some doubts, after asking others, so it is not my own opinion), JSON seems a better choice.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96289/new/

https://reviews.llvm.org/D96289