[PATCH] D96631: [flang] Detect circularly defined procedures

[Tim Keith via Phabricator via llvm-commits]

tskeith added inline comments.


================
Comment at: flang/lib/Evaluate/characteristics.cpp:659
+  }
+  return result;
+}
----------------
FYI, llvm has utility functions in `llvm/ADT/STLExtras.h` that simplify this kind of thing. If you take my suggestion of enclosing each procedure name in quotes you could implement this function as:
```
  llvm::interleave(
      seenProcs,
      [&](const Symbol *p) { result += '\'' + p->name().ToString() + '\''; },
      [&]() { result += ", "; });
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96631/new/

https://reviews.llvm.org/D96631