[PATCH] D96290: [tools] UpdateTestPrefix: improved verbosity

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 15 10:50:03 PST 2021


mtrofin added a comment.

In D96290#2563855 <https://reviews.llvm.org/D96290#2563855>, @RKSimon wrote:

> It comes down to us wanting the update scripts to use lists of check-prefixes for every RUN line, allowing us to share prefixes at the function level, typically getting more and more specific down the list. That way we can minimise bloat in the check lines, but still have thorough coverage with many RUNs.
>
> With the move to avoid unused prefixes, there's going to be a lot more cases where the prefix lists need editing every time a test is changed - we need the update scripts to tell us both when a prefix becomes newly unused, but also when a run suddenly isn't checked at all.

I'm confused - IIRC (https://lists.llvm.org/pipermail/llvm-dev/2021-February/148309.html), the scenario for update_[llc]_test_checks was better nuanced, and it seemed like the position was that a) those tests could, indeed, validly feature unused prefixes, and b) the tools (update_[]_test_checks) would potentially handle that, or the tests would explicitly opt in.

This patch was about addressing overly-verbose messages - https://lists.llvm.org/pipermail/llvm-dev/2021-February/148272.html


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96290/new/

https://reviews.llvm.org/D96290



More information about the llvm-commits mailing list