[PATCH] D95943: [ThinLTO] Fix import of a global variable to modules contain its weak def

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 15 10:34:44 PST 2021


MaskRay added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/FunctionImport.cpp:288
+    if (GVS != DefinedGVSummaries.end()) {
+      if (VI.getSummaryList().size() > 1 &&
+          GlobalValue::isInterposableLinkage(GVS->second->linkage())) {
----------------
Nit: flip the condition so that the "then" branch can be deleted, and the comment can be dedented by one level.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95943/new/

https://reviews.llvm.org/D95943



More information about the llvm-commits mailing list