[PATCH] D96662: [lit] Add --skip (inverse of --filter) and `--xfail`

David Zarzycki via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 15 08:54:07 PST 2021


davezarzycki added inline comments.


================
Comment at: llvm/docs/CommandGuide/lit.rst:215
+  Skip those tests whose name matches the regular expression specified in
+  ``REGEXP``. The environment variable ``LIT_SKIP`` can be also used in place
+  of this option, which is especially useful in environments where the call
----------------
jdenny wrote:
> Why do we need more environment variables?  Isn't `LIT_OPTS` sufficient?  (`LIT_FILTER`, etc. predate `LIT_OPTS`.)
I'm generally biased against designs that require thinking about shell escaping (or at least more than necessary).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96662/new/

https://reviews.llvm.org/D96662



More information about the llvm-commits mailing list