[PATCH] D96499: [debuginfo-tests] Remove explicit checks for Python 3

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 15 06:15:19 PST 2021


jhenderson added a comment.

In D96499#2560198 <https://reviews.llvm.org/D96499#2560198>, @aprantl wrote:

> So CMake for LLVM will fail without Python3?
> If that's the case then this LGTM.

Yes, the LLVM core `CMakeLists.txt` located at `llvm/CMakeLists.txt` already has the check that has been removed from the debuginfo-tests. As debuginfo-tests cannot be configured by a direct CMake execution, this seems reasonable to me (even if CMake did somehow successfully generate targets for check-debuginfo-tests or similar, it would quickly fail if the user wasn't using python 3).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96499/new/

https://reviews.llvm.org/D96499



More information about the llvm-commits mailing list