[PATCH] D96707: AMDGPU: Fix debug info handling in post-RA bundler

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 15 06:03:33 PST 2021


arsenm created this revision.
arsenm added reviewers: rampitec, scott.linder, RamNalamothu, vpykhtin.
Herald added subscribers: kerbowa, hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl.
arsenm requested review of this revision.
Herald added a subscriber: wdng.
Herald added a project: LLVM.

This was allowing debug instructions to break the bundling, which
would change scheduling behavior. Bundle debug info / kills inside
the bundle. This seems to work OK, although the asm printer doesn't
understand these in a bundle. This implicitly expects the memory
legalizer to unbundle. It would probably be slightly nicer to move
these after.

      

Rewrite the loop to be clearer and make sure we don't end a bundle on
a meta instruction, only allow them in between other valid bundle
instructions.


https://reviews.llvm.org/D96707

Files:
  llvm/lib/Target/AMDGPU/SIPostRABundler.cpp
  llvm/test/CodeGen/AMDGPU/post-ra-soft-clause-dbg-info.ll
  llvm/test/CodeGen/AMDGPU/postra-bundle-memops.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D96707.323730.patch
Type: text/x-patch
Size: 14944 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210215/581e9db4/attachment.bin>


More information about the llvm-commits mailing list