[PATCH] D96529: [NFC][VPlan] Use VPUser to store block's predicate

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 15 02:08:07 PST 2021


fhahn added a comment.

Thanks for taking a stab at this after D95382 <https://reviews.llvm.org/D95382>!



================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:584
 
-  VPValue *getPredicate() { return Predicate; }
+  VPValue *getPredicate() {
+    if (PredicateUser.getNumOperands())
----------------
The functions here are essentially the same as for CondBit, right? Could you factor out the logic into private helpers, that take a reference to `VPUser`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96529/new/

https://reviews.llvm.org/D96529



More information about the llvm-commits mailing list