[PATCH] D96310: [llvm-objcopy] Delete --build-id-link-{dir,input,output}

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.

LGTM!



================
Comment at: llvm/tools/llvm-objcopy/ELF/Object.h:446
 
+  ArrayRef<uint8_t> Contents;
+
----------------
MaskRay wrote:
> MaskRay wrote:
> > jhenderson wrote:
> > > jhenderson wrote:
> > > > MaskRay wrote:
> > > > > jhenderson wrote:
> > > > > > This change seems unrelated?
> > > > > This is natural after the last public user of Contents is deleted.
> > > > > 
> > > > > It does not seem necessary to defer it to a subsequent clean-up.
> > > > I'd agree with that, except I can't see where Contents was previously being used?
> > > Ping this? I have no issue with it being moved, but if it wasn't being used publicly before this patch, it probably should be a separate change.
> > The original patch adding the featured move the variable.
> I checked that the variable can be moved without the patch. So I dropped it.
Thanks. Feel free to make a separate commit to move it if you haven't already.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96310/new/

https://reviews.llvm.org/D96310