[PATCH] D95881: [ARM] Extend search for increment in load/store optimizer

[Simon Tatham via Phabricator via llvm-commits]

simon_tatham accepted this revision.
simon_tatham added a comment.

I was lucky to notice it at all – I only spotted it because one of the test changes in the previous version of the patch //did// lift an increment of SP past two load instructions. As best I could tell it wasn't harmful in that particular case, but that clued me in to look more closely and see whether it could have been harmful in another case.

LGTM with the SP exemption, thanks.



================
Comment at: llvm/lib/Target/ARM/ARMLoadStoreOptimizer.cpp:1262
+    // MBBI, otherwise we may be incrementing the stack pointer (invalidating
+    // anything below the new pointer) when it's frame elements are still in
+    // use. Other registers can attempt to look further, until a different use
----------------
(spelling nit, if you can be bothered: it's → its)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95881/new/

https://reviews.llvm.org/D95881