[PATCH] D96164: [lld-macho] add code signature for native arm64 macOS

Sun Feb 14 20:54:15 PST 2021

gkm marked an inline comment as done.
gkm added a comment.

In D96164#2562655 <https://reviews.llvm.org/D96164#2562655>, @thakis wrote:

> Re the copy stuff: See the CL desc and openradar link in https://reviews.llvm.org/rGba3bc2fd41b8428904fc779e353d3769074d8982

That is good to know. This case differs: LLD is not overwriting an existing file, so is not reusing an inode.

There is something funky in `FileOutputBuffer`, which creates the LLD output file via mmap(2). When I force it to avoid mmap, all is well. For now, I will work-around by passing the flag `F_no_mmap` when signing.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96164/new/

https://reviews.llvm.org/D96164