[PATCH] D96164: [lld-macho] add code signature for native arm64 macOS

Sun Feb 14 17:12:43 PST 2021

gkm marked an inline comment as done.
gkm added a comment.

In D96164#2562311 <https://reviews.llvm.org/D96164#2562311>, @tschuett wrote:

> Does codesign.go make any differences?

I haven't tried, but I expect it would work. Resigning with `/usr/bin/codesign` works. Heck, just copying the binary causes it to work!

================
Comment at: lld/MachO/SyntheticSections.cpp:925
+  write32be(&codeDirectory->flags,
+            0x20002); // adhoc | linkerSigned
+  write32be(&codeDirectory->hashOffset,
----------------
tschuett wrote:
> Would it help readability to change this to:
> CS_ADHOC  | CS_LINKER_SIGNED ?
Those are good things. I intend to find & import headers with those enums.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96164/new/

https://reviews.llvm.org/D96164