[PATCH] D96677: [AVR] Expand large shifts early in IR

[Ayke via Phabricator via llvm-commits]

aykevl created this revision.
aykevl added a reviewer: dylanmckay.
Herald added subscribers: Jim, hiraditya.
aykevl requested review of this revision.
Herald added a project: LLVM.

This patch makes sure shift instructions such as this one:

  %result = shl i32 %n, %amount

are expanded just before the IR to SelectionDAG conversion to a loop so that calls to non-existing library functions such as `__ashlsi3` are avoided. The generated code is currently pretty bad but there's a lot of room for improvement: the shift itself can be done in just four instructions.

---

I have tested this patch locally with my set of compiler-rt based tests and all tests that previously passed still pass.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D96677

Files:
  llvm/lib/Target/AVR/AVRRegisterInfo.td
  llvm/test/MC/AVR/registers.s


Index: llvm/test/MC/AVR/registers.s
===================================================================
--- /dev/null
+++ llvm/test/MC/AVR/registers.s
@@ -0,0 +1,33 @@
+; RUN: llvm-mc -triple avr -show-encoding < %s | FileCheck %s
+; RUN: llvm-mc -filetype=obj -triple avr < %s | llvm-objdump -d - | FileCheck -check-prefix=CHECK-INST %s
+
+; Test register aliases: the upper 6 registers have aliases that can be used in
+; assembly.
+
+foo:
+  inc xl
+  inc xh
+  inc yl
+  inc yh
+  inc zl
+  inc zh
+
+  inc XL ; test uppercase
+
+; CHECK: inc r26                    ; encoding: [0xa3,0x95]
+; CHECK: inc r27                    ; encoding: [0xb3,0x95]
+; CHECK: inc r28                    ; encoding: [0xc3,0x95]
+; CHECK: inc r29                    ; encoding: [0xd3,0x95]
+; CHECK: inc r30                    ; encoding: [0xe3,0x95]
+; CHECK: inc r31                    ; encoding: [0xf3,0x95]
+
+; CHECK: inc r26                    ; encoding: [0xa3,0x95]
+
+; CHECK-INST: inc r26
+; CHECK-INST: inc r27
+; CHECK-INST: inc r28
+; CHECK-INST: inc r29
+; CHECK-INST: inc r30
+; CHECK-INST: inc r31
+
+; CHECK-INST: inc r26
Index: llvm/lib/Target/AVR/AVRRegisterInfo.td
===================================================================
--- llvm/lib/Target/AVR/AVRRegisterInfo.td
+++ llvm/lib/Target/AVR/AVRRegisterInfo.td
@@ -67,12 +67,12 @@
 def R23 : AVRReg<23, "r23">, DwarfRegNum<[23]>;
 def R24 : AVRReg<24, "r24">, DwarfRegNum<[24]>;
 def R25 : AVRReg<25, "r25">, DwarfRegNum<[25]>;
-def R26 : AVRReg<26, "r26">, DwarfRegNum<[26]>;
-def R27 : AVRReg<27, "r27">, DwarfRegNum<[27]>;
-def R28 : AVRReg<28, "r28">, DwarfRegNum<[28]>;
-def R29 : AVRReg<29, "r29">, DwarfRegNum<[29]>;
-def R30 : AVRReg<30, "r30">, DwarfRegNum<[30]>;
-def R31 : AVRReg<31, "r31">, DwarfRegNum<[31]>;
+def R26 : AVRReg<26, "r26", [], ["xl"]>, DwarfRegNum<[26]>;
+def R27 : AVRReg<27, "r27", [], ["xh"]>, DwarfRegNum<[27]>;
+def R28 : AVRReg<28, "r28", [], ["yl"]>, DwarfRegNum<[28]>;
+def R29 : AVRReg<29, "r29", [], ["yh"]>, DwarfRegNum<[29]>;
+def R30 : AVRReg<30, "r30", [], ["zl"]>, DwarfRegNum<[30]>;
+def R31 : AVRReg<31, "r31", [], ["zh"]>, DwarfRegNum<[31]>;
 def SPL : AVRReg<32, "SPL">, DwarfRegNum<[32]>;
 def SPH : AVRReg<33, "SPH">, DwarfRegNum<[33]>;
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D96677.323647.patch
Type: text/x-patch
Size: 2254 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210215/435afbe2/attachment.bin>