[PATCH] D96641: [XCOFF] [NFC] make StorageMappingClass/SymbolType member optional in MCSectionXCOFF class

[ChenZheng via Phabricator via llvm-commits]

shchenz added inline comments.


================
Comment at: llvm/include/llvm/MC/MCSectionXCOFF.h:35-36
 
-  XCOFF::StorageMappingClass MappingClass;
-  XCOFF::SymbolType Type;
+  Optional<XCOFF::CsectProperties> CsectProp;
+  bool IsCsect;
   MCSymbolXCOFF *const QualName;
----------------
hubert.reinterpretcast wrote:
> If `IsCsect` is true exactly when `CsectProp` is not `None`, then I suggest just using `CsectProp` and having `isCsect()` return `static_cast<bool>(CsectProp)`.
Thanks, updated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96641/new/

https://reviews.llvm.org/D96641