[PATCH] D96641: [XCOFF] [NFC] make StorageMappingClass/SymbolType member optional in MCSectionXCOFF class

ChenZheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 13 20:05:19 PST 2021


shchenz added a comment.

Thanks for your review @hubert.reinterpretcast @MaskRay

Since now the `get` functions are not optional, so it should not impact the callers of them. But we need to revisit these functions when we add object output XCOFF DWARF support. I will leave the handlings in that follow up patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96641/new/

https://reviews.llvm.org/D96641



More information about the llvm-commits mailing list