[PATCH] D91516: [AMDGPU][WIP] Lower LDS Global Variables.

[Mahesha S via Phabricator via llvm-commits]

hsmhsm added a comment.

In D91516#2562027 <https://reviews.llvm.org/D91516#2562027>, @jdoerfert wrote:

> In D91516#2561383 <https://reviews.llvm.org/D91516#2561383>, @hsmhsm wrote:
>
>> In D91516#2560020 <https://reviews.llvm.org/D91516#2560020>, @jdoerfert wrote:
>>
>>> Could we get some tests *and* a commit message that explains what this is supposed to do.
>>
>> This is WIP, will add test and commit messages at the end before final review.
>
> I generally would recommend against that but I guess you can use phabricator this way.
> However, once people can figure out what this is actually supposed to do, they might effectively restart the entire review process if the design is questioned.
> I say this because I have a hunch, or maybe a hope, about the intent of this patch. If it would be that, I'd very much like this to be a generic, non-AMDGPU pass. I might be wrong about what this does, and that is what I'd like to figure out rather sooner than later.

OK let's wait for the complete patch then. I will only going to push complete patch next time. But, it may take some time since there are some major hurdles to overcome.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91516/new/

https://reviews.llvm.org/D91516