[PATCH] D95931: [XCOFF] [NFC] make csect properties optional for function getXCOFFSection

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast accepted this revision.
hubert.reinterpretcast added a comment.
This revision is now accepted and ready to land.

LGTM with minor comment.



================
Comment at: llvm/lib/MC/MCContext.cpp:674
+  auto IterBool = XCOFFUniquingMap.insert(std::make_pair(
+      XCOFFSectionKey{Section.str(), (XCOFF::StorageMappingClass)CsectProp.SMC},
+      nullptr));
----------------
shchenz wrote:
> hubert.reinterpretcast wrote:
> > This is eventually going to need to handle the case where the section is not a csect, but for this patch, I think it is okay to write it as it all XCOFF sections are csects. The patch that introduces non-csect XCOFF sections will need to do the update to this.
> Updated in D95518 and I added a new NFC patch D96641 to make class member also optional
Thanks. Let's have a TODO comment about this function's need for revision to handle non-csects in the code anyway (so this patch is better self-contained).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95931/new/

https://reviews.llvm.org/D95931