[PATCH] D96641: [XCOFF] [NFC] make StorageMappingClass/SymbolType member optional in MCSectionXCOFF class
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Feb 13 14:18:42 PST 2021
MaskRay added inline comments.
================
Comment at: llvm/lib/MC/MCSectionXCOFF.cpp:42
if (getKind().isData()) {
- switch (getMappingClass()) {
+ assert(getMappingClass() && "Data kind section should be a csect.");
+ switch (getMappingClass().getValue()) {
----------------
assert is not needed because getValue() would fail too
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96641/new/
https://reviews.llvm.org/D96641
More information about the llvm-commits
mailing list