[PATCH] D96643: [AMDGPU] Limit memory scope for scratch, LDS and GDS

Sat Feb 13 14:08:51 PST 2021

rampitec added a comment.

Gerrit is down until 11pm CT according to IT.

Stas

- Original message ---

From: Tony Tye via Phabricator reviews at reviews.llvm.org
Sent: February 13, 2021 13:52:43
To: Tye, Tony Tony.Tye at amd.com, Zhuravlyov, Konstantin Konstantin.Zhuravlyov at amd.com, Linder, Scott Scott.Linder at amd.com, Sumner, Brian Brian.Sumner at amd.com, Mekhanoshin, Stanislav Stanislav.Mekhanoshin at amd.com
CC: madhur13490 at gmail.com, wei.ding2 at amd.com, llvm-commits at lists.llvm.org, Arsenault, Matthew Matthew.Arsenault at amd.com, jv356 at scarletmail.rutgers.edu, nhaehnle at gmail.com, Liu, Yaxun (Sam) Yaxun.Liu at amd.com, Stuttard, David David.Stuttard at amd.com, tpr.ll at botech.co.uk, reviews.llvm.org at jfbastien.com, Kerbow, Austin Austin.Kerbow at amd.com, Kumar N, Bhuvanendra Bhuvanendra.KumarN at amd.com, 88888yl at gmail.com, dougpuob at gmail.com, Neubauer, Sebastian Sebastian.Neubauer at amd.com, Song, Ruiling Ruiling.Song at amd.com
Subject: [PATCH] D96643 <https://reviews.llvm.org/D96643>: [AMDGPU] Limit memory scope for scratch, LDS and GDS

[CAUTION: External Email]

t-tye added a comment.

In D96643#2561617 <https://reviews.llvm.org/D96643#2561617> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD96643%232561617&data=04%7C01%7Cstanislav.mekhanoshin%40amd.com%7Ce267676049fe4e987bda08d8d069ae2b%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637488499635053925%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=gtSTLQKaH1%2FU22bx0vE3BSOOZ50ZhryRfYwQXHvYv20%3D&reserved=0, @rampitec wrote:

LGTM, thanks Tony!
It is up to you to use min() or if(). I will postpone my patch to rebase on top your change as I expect to have zero test changes with my patch after this one and want to make sure this expectation is correct.

I made the changes, thanks. I am waiting to get executable test results but Gerrit is currently down.

Repository:

  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION

  https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD96643%2Fnew%2F&data=04%7C01%7Cstanislav.mekhanoshin%40amd.com%7Ce267676049fe4e987bda08d8d069ae2b%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637488499635053925%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=ywkjGAacWwABrPmLCAfpRqa6spSOUy6RG2gqAQpTG0A%3D&reserved=0

https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD96643&data=04%7C01%7Cstanislav.mekhanoshin%40amd.com%7Ce267676049fe4e987bda08d8d069ae2b%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637488499635053925%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=2B1xLZkK6f6lfkQXZOBHIjm99SMU2iKiJGoNs3%2FSqXo%3D&reserved=0

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96643/new/

https://reviews.llvm.org/D96643