[PATCH] D96650: [NFC] Replace OuterLoopId with InnerLoopId - 1

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 13 10:15:04 PST 2021


fhahn added a comment.

> The main reason for this refactor is to help passing ArrayRef to function processLoop() (remove the need to swap elements in loop list).

Could you elaborate why this is needed to pass `ArrayRef`?  I think stylistically passing the outer-loop Id explicitly makes the functions a bit clearer and the functions currently are written in a way that does not rely on passing adjacent loops. If possible to keep the parameters, I think that would be preferable, rather than making the code less flexible. Otherwise there are various places where comments need updating.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96650/new/

https://reviews.llvm.org/D96650



More information about the llvm-commits mailing list