[PATCH] D95993: Add auto-upgrade support for annotation intrinsics

Tyker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 13 04:33:50 PST 2021


Tyker added inline comments.


================
Comment at: llvm/lib/IR/AutoUpgrade.cpp:3759
+    // the old call and replace the uses.
+    if (!CI->use_empty()) {
+      Value *NewRetVal = Builder.CreateBitCast(NewCall, CI->getType());
----------------
Tyker wrote:
> since the return type of annotation didn't change i am not sure this is necessary.
i am not sure the bitcast is necessary.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95993/new/

https://reviews.llvm.org/D95993



More information about the llvm-commits mailing list