[PATCH] D96287: [TTI] Change getOperandsScalarizationOverhead to take Type args

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added a comment.

LGTM, thanks @dmgreen!



================
Comment at: llvm/include/llvm/Analysis/TargetTransformInfo.h:727
+  /// non-constant operands. The (potentially vector) types to use for each of
+  /// argument are passes via Tys.
   unsigned getOperandsScalarizationOverhead(ArrayRef<const Value *> Args,
----------------
nit: `\p Tys`


================
Comment at: llvm/include/llvm/CodeGen/BasicTTIImpl.h:639
+  /// Estimate the overhead of scalarizing the inputs and outputs of an
+  /// instruction, with return type RetTy and arguments Args of type Tys. If
+  /// Args are unknown (empty), then the cost associated with one argument is
----------------
nit: `\p RetTy`, `\p Args` and `\p Tys`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96287/new/

https://reviews.llvm.org/D96287