[PATCH] D95217: [LoopVectorize] Fix VPRecipeBuilder::createEdgeMask to correctly generate the mask

Juneyoung Lee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 12 22:01:57 PST 2021


aqjune marked 5 inline comments as done.
aqjune added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:8256
+    EdgeMask =
+        Builder.createNaryOp(Instruction::Select, {SrcMask, EdgeMask, False});
+  }
----------------
fhahn wrote:
> nit: Just use `Builder.CreateSelect`?
I added createSelect to VPBuilder because having one seems good to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95217/new/

https://reviews.llvm.org/D95217



More information about the llvm-commits mailing list