[PATCH] D96398: [LTO] Perform DSOLocal propagation in combined index

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added a comment.

Looks good except for the BitstreamReader change - I'm not sure why this would affect that?



================
Comment at: llvm/include/llvm/Bitstream/BitstreamReader.h:196
 
-    static const unsigned Mask = sizeof(word_t) > 4 ? 0x3f : 0x1f;
+    static const unsigned Mask = sizeof(word_t) > 4 ? 0x7f : 0x1f;
 
----------------
Why this change?


================
Comment at: llvm/lib/IR/ModuleSummaryIndex.cpp:218
 
-// Do the access attribute propagation in combined index.
+// Do the access attribute and DSOLocal propagation in combined index.
 // The goal of attribute propagation is internalization of readonly (RO)
----------------
Thanks, can you update the header declaration's comment as well?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96398/new/

https://reviews.llvm.org/D96398