[PATCH] D96501: [FPEnv][ARM] Implement lowering of llvm.set.rounding

Serge Pavlov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 12 20:39:57 PST 2021


sepavloff added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:6148
+  SDValue Ops[] = {Chain,
+                   DAG.getConstant(Intrinsic::arm_get_fpscr, DL, MVT::i32)};
+  SDValue FPSCR =
----------------
craig.topper wrote:
> Intrinsic IDs should use getTargetConstant I think, but it looks like ARM is already inconsistent on this. Not sure about other targets.
AArch64 is inconsistent as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96501/new/

https://reviews.llvm.org/D96501



More information about the llvm-commits mailing list