[PATCH] D96631: [flang] Detect circularly defined procedures

[Pete Steinfeld via Phabricator via llvm-commits]

PeteSteinfeld added a comment.

In D96631#2561336 <https://reviews.llvm.org/D96631#2561336>, @klausler wrote:

> I think there's ways by which the characteristics of a procedure could be self-dependent besides the use of a dummy procedure, so you might want a less specific error.  But that's probably the most common way that a user can get themselves into trouble with this sort of thing, so you might be okay.  Improve or change the message as you like, or not.  Maybe Tim can suggest better wording.

Thanks, Peter.  It occurred to me that I can also improve the message by including the names of all of the procedures in the cycle as part of the error message.  I'll be producing another update that does that.  Let me know what you think when I update the commit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96631/new/

https://reviews.llvm.org/D96631