[PATCH] D96559: Support emitting complex expressions that include entry values

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro accepted this revision.
djtodoro added a comment.
This revision is now accepted and ready to land.

thanks! Lgtm



================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfExpression.cpp:287
   // location, emit it with addBReg and offset 0, because we should emit a DWARF
   // expression representing a value, rather than a location.
+  if ((!isParameterValue() && !isMemoryLocation() && !HasComplexExpression) ||
----------------
vsk wrote:
> Maybe expand the comment with:
> + // Also handle the start of an entry value expression, even if it's complex.
+1


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96559/new/

https://reviews.llvm.org/D96559