[PATCH] D96387: [CSSPGO][llvm-profgen] Renovate perfscript check and command line input validation

[Lei Wang via Phabricator via llvm-commits]

wlei added inline comments.


================
Comment at: llvm/tools/llvm-profgen/ProfiledBinary.cpp:27
+static cl::opt<bool, true>
+    PrintDisassemblyOnly("show-disassembly-only", cl::ReallyHidden,
+                         cl::ZeroOrMore, cl::desc("Print disassembled code."),
----------------
wenlei wrote:
> This works, but we could make it simpler:
> 
> ProfileBinary.cpp:
> 
> ```
> cl::opt<bool> ShowDisassembly("show-disassembly", cl::ReallyHidden,
>                                      cl::init(false), cl::ZeroOrMore,
>                                      cl::desc("Print disassembled code."));
> ```
> 
> llvm-profgen.cpp:
> 
> ```
> extern cl::opt<bool> ShowDisassembly;
> ```
Yeah, learned it!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96387/new/

https://reviews.llvm.org/D96387