[PATCH] D88392: [M68k] (Patch 6/8) IR Tests

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added a comment.

As I've said before, please use update_llc_test_checks.py. Manually-maintained CHECK lines are a complete pain when making tree-wide changes.



================
Comment at: llvm/utils/extract-section.py:1
+#!/usr/bin/env python
+from __future__ import print_function
----------------
myhsu wrote:
> MaskRay wrote:
> > If not used, please drop it.
> > 
> > `llvm-objcopy --dump-section=.foo=file a.o /dev/null`
> If you're referring to this script as a whole, it is used extensively in M68k's test suite. 
> 
> This script is designed for printing certain section in //textual// format. So I'm afraid your llvm-objcopy command might not be sufficient. As the comment below described, this script is similar to llvm-readobj but the latter only support one output format (i.e. hex with lots of redundant info like ASCii decoding), where in many cases, we want other formats like hex string with different width and textual bits.
I'm with MaskRay, this script shouldn't exist, use the existing llvm tools.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88392/new/

https://reviews.llvm.org/D88392