[PATCH] D96109: Refactor implementation of -funique-internal-linkage-names.

[Sriraman Tallam via Phabricator via llvm-commits]

tmsriram added inline comments.


================
Comment at: clang/include/clang/Basic/Attr.td:2159
 
+def UniqueInternalLinkageSuffix : Attr {
+  // This attribute has no spellings as it is only ever created implicitly.
----------------
aaron.ballman wrote:
> Should this attribute be inherited by redeclarations?
The attribute is added in EmitTopLevelDecl in CodeGenModule which happens after  ActOnDeclarator in SemaDecl.cpp.  I dont think this needs to be inherited but I am not sure. Is there an example I can use to check if this is fine?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96109/new/

https://reviews.llvm.org/D96109