[compiler-rt] 394913f - Try to fix external_symbolizer_path.cpp test to stop breaking on buildbots.

Amy Huang via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 12 10:17:09 PST 2021


Author: Amy Huang
Date: 2021-02-12T10:16:49-08:00
New Revision: 394913fdb96af1a8ab699140f23073f2f366f406

URL: https://github.com/llvm/llvm-project/commit/394913fdb96af1a8ab699140f23073f2f366f406
DIFF: https://github.com/llvm/llvm-project/commit/394913fdb96af1a8ab699140f23073f2f366f406.diff

LOG: Try to fix external_symbolizer_path.cpp test to stop breaking on buildbots.

Not sure what the issue is, but it might be because the test copies
llvm-symbolizer to a different directory, and it can't find libc++.
Try to add some REQUIRES that we use in other tests where we copy
llvm tools out of their original directories.

Added: 
    

Modified: 
    compiler-rt/test/sanitizer_common/TestCases/external_symbolizer_path.cpp

Removed: 
    


################################################################################
diff  --git a/compiler-rt/test/sanitizer_common/TestCases/external_symbolizer_path.cpp b/compiler-rt/test/sanitizer_common/TestCases/external_symbolizer_path.cpp
index 118fdc9eada0..7203ce01266a 100644
--- a/compiler-rt/test/sanitizer_common/TestCases/external_symbolizer_path.cpp
+++ b/compiler-rt/test/sanitizer_common/TestCases/external_symbolizer_path.cpp
@@ -1,3 +1,10 @@
+// If the binary looks up libraries using an rpath, we can't test this
+// without copying the whole lib dir or polluting the build dir.
+// REQUIRES: static-libs
+
+// The above also applies if the binary is built with libc++.
+// UNSUPPORTED: libcxx-used
+
 // REQUIRES: shell
 // REQUIRES: x86-target-arch
 // RUN: rm -rf %t.bin


        


More information about the llvm-commits mailing list