[PATCH] D96434: [CSSPGO][llvm-profgen] Filter out the instructions without location info for symbolizer

[Wenlei He via Phabricator via llvm-commits]

wenlei added inline comments.


================
Comment at: llvm/tools/llvm-profgen/ProfiledBinary.cpp:161
+    if (ExpandedContext.empty())
+      return "";
     for (const auto &Loc : ExpandedContext) {
----------------
nit: `return std::string()`


================
Comment at: llvm/tools/llvm-profgen/ProfiledBinary.h:237
+  Optional<const FrameLocation> getInlineLeafFrameLoc(uint64_t Offset,
+                                                      bool NameOnly = false) {
+    auto &Stack = getFrameLocationStack(Offset);
----------------
do we still need `NameOnly` parameter?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96434/new/

https://reviews.llvm.org/D96434