[PATCH] D95969: [WPD] Add an optional checking mode for debugging devirtualization

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/WholeProgramDevirt.cpp:1065
+        // devirtualized. The original call can be replaced with the trap.
+        CallBase &NewInst = versionCallSite(VCallSite.CB, TheFn);
+        NewInst.setCalledOperand(ConstantExpr::getBitCast(
----------------
is versioning necessary here? Can it just be:

if (target != direct_target)
  trap();
direct_target();


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95969/new/

https://reviews.llvm.org/D95969