[PATCH] D96531: TransformUtils: Fix metadata handling in CloneModule (and improve CloneFunctionInto)

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 12 09:20:46 PST 2021


aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

One question inline, otherwise I think this makes sense.



================
Comment at: llvm/lib/Transforms/Utils/CloneModule.cpp:188
     const NamedMDNode &NMD = *I;
     NamedMDNode *NewNMD = New->getOrInsertNamedMetadata(NMD.getName());
+    for (unsigned i = 0, e = NMD.getNumOperands(); i != e; ++i)
----------------
Why is this no longer necessary?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96531/new/

https://reviews.llvm.org/D96531



More information about the llvm-commits mailing list