[PATCH] D96173: [ThinLTO][gold] Fix filenaming scheme for tasks.

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 12 08:49:25 PST 2021


tejohnson accepted this revision.
tejohnson added a comment.

lgtm with a minor request below.



================
Comment at: llvm/tools/gold/gold-plugin.cpp:919
+      SmallString<128> TaskFilename;
+      getOutputFileName(output_name, false, TaskFilename, Task);
+      raw_fd_ostream OS(TaskFilename, EC, sys::fs::OpenFlags::OF_None);
----------------
Document constant bool parameter. I.e. "/* TempOutFile */ false"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96173/new/

https://reviews.llvm.org/D96173



More information about the llvm-commits mailing list