[PATCH] D96600: [TTI] Unify FavorPostInc and FavorBackedgeIndex into getAddressingMode

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: llvm/include/llvm/Analysis/TargetTransformInfo.h:648
+  /// Return the preferred addressing mode LSR should make efforts to generate.
+  AddressingModeKind getAddressingMode(const Loop *L) const;
 
----------------
I feel like the name is too general, and should be most specific to this favoring one mode or the other in LSR. Maybe just adding Preferred or Favor to it would be enough.


================
Comment at: llvm/lib/Target/ARM/ARMTargetTransformInfo.cpp:104
+TTI::AddressingModeKind ARMTTIImpl::getAddressingMode(const Loop *L) const {
+  if (L->getHeader()->getParent()->hasOptSize() && ST->hasMVEIntegerOps())
+    return TTI::AMK_PostIndexed;
----------------
Is this not still different for optsize?


================
Comment at: llvm/lib/Target/ARM/ARMTargetTransformInfo.cpp:106
+    return TTI::AMK_PostIndexed;
+  else if (L->getHeader()->getParent()->hasOptSize())
+    return TTI::AMK_None;
----------------
Doesn't need the else after a return.


================
Comment at: llvm/lib/Target/ARM/ARMTargetTransformInfo.cpp:113-114
 
-bool ARMTTIImpl::shouldFavorPostInc() const {
   if (ST->hasMVEIntegerOps())
-    return true;
-  return false;
+    return TTI::AMK_PostIndexed;
+
----------------
I don't think this should be needed?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96600/new/

https://reviews.llvm.org/D96600