[PATCH] D96486: [RISCV] Support scalable-vector masked scatter operations

[Fraser Cormack via Phabricator via llvm-commits]

frasercrmck added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:2117
+  SDValue Ops[] = {N->getChain(), cast<MaskedScatterSDNode>(N)->getValue(),
+                   Mask, N->getBasePtr(), Index};
+  return DAG.getMemIntrinsicNode(RISCVISD::MSCATTER, DL,
----------------
craig.topper wrote:
> Is there a truncating scatter? Should we assert that this isn't one like we do for extending MGATHER?
Yes, we should. It was tested in this MR but I forgot to put the assert in. Cheers!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96486/new/

https://reviews.llvm.org/D96486