[PATCH] D96605: AMDGPU/GlobalISel: Remove redundant G_FCANONICALIZE

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 12 07:41:34 PST 2021


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUPostLegalizerCombiner.cpp:253-255
+  unsigned SrcOpcode = MRI.getVRegDef(Reg)->getOpcode();
+  return SrcOpcode == AMDGPU::G_FMINNUM_IEEE ||
+         SrcOpcode == AMDGPU::G_FMAXNUM_IEEE;
----------------
Really we should have an isCanonicalized utility function like we do in the DAG rather than special casing these two


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96605/new/

https://reviews.llvm.org/D96605



More information about the llvm-commits mailing list