[PATCH] D95373: Replace vector intrinsics with call to vector library

[David Sherwood via Phabricator via llvm-commits]

david-arm added a comment.

Hi @spatel, I think that fix looks sensible, although I'd recommend initialising the ElementCount to something in the same way as `VF = 0` rather than relying upon the default constructor behaviour. You can write this as:

`ElementCount VF = ElementCount::getFixed(0);`

and this ensures it's initialised to the value that you expect. Also you might want to explicitly check for non-zero element counts, i.e.:

`if (VF.isNonZero() && VF != NumElements) {`

Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95373/new/

https://reviews.llvm.org/D95373