[PATCH] D95245: [SVE] Add support for scalable vectorization of loops with int/fast FP reductions

[David Sherwood via Phabricator via llvm-commits]

david-arm accepted this revision.
david-arm added a comment.

LGTM! Latest version looks good and I think you've addressed @sdesmalen's comments. Thanks!



================
Comment at: llvm/test/Transforms/LoopVectorize/AArch64/scalable-reductions.ll:376
+
+; Note: This test was added to ensure we always check reductions (and emit a warning if necessary) if the loop also contains memory dependencies
+; CHECK-REMARK: Scalable vectorization not supported for the reduction operations found in this loop. Using fixed-width vectorization instead.
----------------
nit: Perhaps you could make it clear you're testing the ordering, i.e. with something like:

```This test was added to ensure we always check the legality of reductions (end emit a warning if necessary) before checking for memory dependencies```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95245/new/

https://reviews.llvm.org/D95245