[PATCH] D86498: AMDGPU/GlobalISel: Partially move constant selection to patterns

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUGISel.td:312-314
+def gi_bitcast_fpimm_to_i32 : GICustomOperandRenderer<"renderBitcastFPImm32">,
   GISDNodeXFormEquiv<bitcast_fpimm_to_i32>;
+def gi_bitcast_fpimm_to_i64 : GICustomOperandRenderer<"renderBitcastFPImm64">,
----------------
arsenm wrote:
> foad wrote:
> > Can't you call renderBitcastFPImm directly and avoid the 32/64 wrapper functions?
> No, the emitter doesn't handle reusing the same function
D96587


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86498/new/

https://reviews.llvm.org/D86498