[PATCH] D96587: [TableGen][GlobalISel] Allow duplicate RendererFns

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 12 02:23:32 PST 2021


foad created this revision.
foad added reviewers: Paul-C-Anagnostopoulos, arsenm.
Herald added subscribers: kerbowa, mgrang, hiraditya, rovka, nhaehnle, jvesely.
foad requested review of this revision.
Herald added subscribers: llvm-commits, wdng.
Herald added a project: LLVM.

Allow different GICustomOperandRenderers to use the same RendererFn.
This avoids the need for targets to define a bunch of identical C++
renderer functions with different names.

Without this fix TableGen would have emitted code that tried to define
the GICR enumeration with duplicate enumerators.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D96587

Files:
  llvm/lib/Target/AMDGPU/AMDGPUGISel.td
  llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.h
  llvm/test/TableGen/GlobalISelEmitter.td
  llvm/utils/TableGen/GlobalISelEmitter.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D96587.323272.patch
Type: text/x-patch
Size: 6139 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210212/2a2dc047/attachment.bin>


More information about the llvm-commits mailing list